Skip to content

Conversation

@SkymanOne
Copy link
Contributor

NOT READY FOR MERGE

@SkymanOne SkymanOne added the E-dont-merge A pull request that should not be merged. label Feb 1, 2023
@ascjones
Copy link
Collaborator

ascjones commented Feb 7, 2023

I believe these flaky tests should now have been fixed by: #1642

@codecov-commenter
Copy link

Codecov Report

Merging #1638 (047a3bc) into master (ce64dbe) will decrease coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
- Coverage   64.78%   63.94%   -0.85%     
==========================================
  Files         207      207              
  Lines        6376     6376              
==========================================
- Hits         4131     4077      -54     
- Misses       2245     2299      +54     
Impacted Files Coverage Δ
crates/engine/src/chain_extension.rs 19.04% <0.00%> (-23.81%) ⬇️
crates/metadata/src/lib.rs 35.00% <0.00%> (-20.00%) ⬇️
crates/primitives/src/types.rs 0.00% <0.00%> (-20.00%) ⬇️
crates/engine/src/test_api.rs 72.52% <0.00%> (-13.19%) ⬇️
crates/engine/src/ext.rs 55.36% <0.00%> (-13.00%) ⬇️
crates/storage/traits/src/layout/impls.rs 0.00% <0.00%> (-10.00%) ⬇️
crates/metadata/src/layout/mod.rs 77.50% <0.00%> (-3.34%) ⬇️
crates/allocator/src/bump.rs 88.23% <0.00%> (-0.85%) ⬇️
crates/ink/ir/src/ir/attrs.rs 78.26% <0.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SkymanOne SkymanOne closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E-dont-merge A pull request that should not be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants