Use external ink-examples repository
#1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
requested review from
a team,
HCastano,
SkymanOne and
ascjones
as code owners
cmichi
commented
Feb 16, 2023
| the content of `integration-tests` (minus `mother`, `lang-err-integration-tests` and | ||
| `mapping-integration-tests`). Besides copying those folders over, the only change you | ||
| need to do manually is to switch the dependencies in the `Cargo.toml`'s to use the | ||
| published version of your release. |
Collaborator
Author
There was a problem hiding this comment.
Whoever wants to can add a comfy one-line command in a follow-up.
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
==========================================
- Coverage 70.76% 70.71% -0.05%
==========================================
Files 206 206
Lines 6416 6416
==========================================
- Hits 4540 4537 -3
- Misses 1876 1879 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ascjones
approved these changes
Feb 20, 2023
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Glad we are finally doing this!
Some conflicts to resolve but otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder structure preview here.
Following a number of discussions I've set up https://github.com/paritytech/ink-examples.
Some of the reasons to do so were:
masterrelease. They often had already been updated to breaking changes that were not published yet. Hence copy/pasting them resulted in build errors.Cargo.tomlused relative paths for its dependencies.mother).We want to have one dedicated repo where people can just copy/paste existing examples and be sure they work with the latest release.