Skip to content

Usage of the crate includes defined there events #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 2 commits into from
Jul 14, 2023
Merged

Usage of the crate includes defined there events #1842

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b6b0b
Usage of the crate includes defined there events
xgreenx Jul 6, 2023
d0aa0b1
Inclusion of the event from `event_def_unused` is expected
xgreenx Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Inclusion of the event from event_def_unused is expected
  • Loading branch information
@xgreenx
xgreenx committed Jul 13, 2023
commit d0aa0b167ea329b14bda14f1175413fcec962d9c
8 changes: 6 additions & 2 deletions integration-tests/events/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ pub mod events {
}
}

/// Implementing the trait from the `event_def_unused` crate includes all defined
/// events there.
impl event_def_unused::FlipperTrait for Events {
#[ink(message)]
fn flip(&mut self) {
Expand All @@ -92,7 +94,7 @@ pub mod events {
#[test]
fn collects_specs_for_all_linked_and_used_events() {
let event_specs = ink::metadata::collect_events();
assert_eq!(6, event_specs.len());
assert_eq!(7, event_specs.len());

assert!(event_specs
.iter()
Expand All @@ -113,7 +115,9 @@ pub mod events {
.iter()
.any(|evt| evt.label() == &"InlineAnonymousEvent"));

assert!(!event_specs
// The event is not used in the code by being included in the metadata
// because we implement trait form `event_def_unused` crate.
assert!(event_specs
.iter()
.any(|evt| evt.label() == &"EventDefUnused"));
}
Expand Down