Skip to content

Modify static buffer size via env var #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkymanOne merged 14 commits into from
Aug 18, 2023
Merged

Modify static buffer size via env var #1869

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cd25a65
modify buffer size via env var
Aug 7, 2023
0441a0e
fmt
Aug 7, 2023
c2aacd4
add docs and tests
Aug 8, 2023
4a954ae
fmt
Aug 8, 2023
0230c20
fix if-else statement in ci
Aug 8, 2023
338ac2a
do cargo clean before the running the test
Aug 8, 2023
c73ae61
clean binaries the test too
Aug 8, 2023
a698006
add changelog
Aug 9, 2023
c99ac67
remove unused dependency and add an error message
Aug 16, 2023
6c9f6ea
fmt
Aug 16, 2023
612cd3c
rename env var
Aug 16, 2023
6c4ee3b
use const_env instead of build script
Aug 18, 2023
5c86b18
clean up dependencies
Aug 18, 2023
672fddf
comment fix
Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
SkymanOne committed Aug 8, 2023
commit 4a954ae5296c3b0f5886ddb67d4626c9322e608a
6 changes: 4 additions & 2 deletions integration-tests/static-buffer/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ pub mod static_buffer {
type E2EResult<T> = std::result::Result<T, Box<dyn std::error::Error>>;

#[ink_e2e::test]
async fn e2e_run_out_of_buffer_memory<Client: E2EBackend>(mut client: Client) -> E2EResult<()> {
async fn e2e_run_out_of_buffer_memory<Client: E2EBackend>(
mut client: Client,
) -> E2EResult<()> {
// given
let constructor = StaticBufferRef::new(false);
let contract = client
Expand All @@ -57,7 +59,7 @@ pub mod static_buffer {
.expect("instantiate failed");
let call = contract.call::<StaticBuffer>();

//when
// when
let get = call.get_caller();
// then panics if `STATIC_BUFFER_SIZE` is less than 32 bytes.
let res = client.call_dry_run(&ink_e2e::bob(), &get, 0, None).await;
Expand Down