Modify static buffer size via features #1872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2023 12:37
This was referenced Aug 9, 2023
xgreenx
reviewed
Aug 16, 2023
| no-allocator = ["ink_allocator/no-allocator"] | ||
|
|
||
| # Configurable sizes of the static buffer | ||
| 2GB-buffer = [] |
Contributor
There was a problem hiding this comment.
It says that memory is to huge:
| 512MB-buffer = [] | ||
| 128MB-buffer = [] | ||
| 16MB-buffer = [] | ||
| 1MB-buffer = [] |
Contributor
There was a problem hiding this comment.
Starting 1MB it returns another error:
Contributor
Author
|
Closing in favour of #1869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to the #1869 which addresses #1471
Instead of allowing developers to specify the static buffer size, we let them choose the size from the given set of features that we offer:
This range of values should cover most of the use cases.
The benefit over the other PR is that devs don't need to mess with the environmental variables of
.envfiles, and the configuration of the static buffer size is trivially simple eliminating any possibility of human error.We also avoid using build scripts and messing up with the codegen.