-
Notifications
You must be signed in to change notification settings - Fork 481
Restore contract size checks #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WIP Restore contract size checks
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
- Coverage 52.93% 52.92% -0.02%
==========================================
Files 219 219
Lines 6780 6780
==========================================
- Hits 3589 3588 -1
- Misses 3191 3192 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
Link to the run | Last update: Tue Oct 17 11:53:02 CEST 2023 |
| @@ -0,0 +1,188 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Script copied from: https://josh.fail/2022/pure-bash-markdown-table-generator/ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this whole script to generate a markdown table copied from https://josh.fail/2022/pure-bash-markdown-table-generator/
cmichi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌈
Previously the
ink-waterfallstep reported changes in contract sizes for a PR compared tomaster. This was useful for preventing regressions and also for PRs which are designed to improve the contract sizes.This PR restores this check, this time integrated as part of the
inkCI itself.I have split the check into separate script files that can be run locally (apart from
contract_sizes_submit.sh) for easy testing and to make it easy to migrate to GHA later.