Skip to content

Bugfix ink_metadata: RootLayout must work for PortableForm #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xermicus merged 6 commits into from
Nov 13, 2023
Merged

Bugfix ink_metadata: RootLayout must work for PortableForm #1989

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddd6896
RootLayout should work for PortableForm
xermicus Nov 13, 2023
24e21b3
changelog
xermicus Nov 13, 2023
62aaf34
bugfix import path
xermicus Nov 13, 2023
58e78d6
remove spurious fmt
xermicus Nov 13, 2023
a1d8223
remove the inferred type for single generic type params
xermicus Nov 13, 2023
a75f293
remove unecessary param type
xermicus Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unecessary param type 
Signed-off-by: Cyrill Leutwiler <[email protected]>
  • Loading branch information
@xermicus
xermicus committed Nov 13, 2023
commit a75f2936dd825913a76c1518b016fb96976f033b
3 changes: 1 addition & 2 deletions crates/metadata/src/layout/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,7 @@ fn runtime_storage_layout_works() {
#[test]
fn ensure_portable_root_layout_are_supported() {
let root_key = LayoutKey::new(0u32);
let layout =
Layout::Struct(StructLayout::<PortableForm>::new(String::new(), Vec::new()));
let layout = Layout::Struct(StructLayout::new(String::new(), Vec::new()));
let ty = 0.into();

let _: RootLayout<PortableForm> = RootLayout::new(root_key, layout, ty);
Expand Down