Skip to content

Messages return TypeSpec directly #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkymanOne merged 6 commits into from
Nov 20, 2023
Merged

Messages return TypeSpec directly #1999

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d13f24e
Messages return TypeSpec directly
SkymanOne Nov 17, 2023
84ae712
arrange changelog
SkymanOne Nov 17, 2023
843abd4
remove `Option` in `ReturnTypeSpec` + adjust tests
SkymanOne Nov 20, 2023
09d976e
remove rubbish
SkymanOne Nov 20, 2023
099602e
fix tests
SkymanOne Nov 20, 2023
178d4ff
fix docs
SkymanOne Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@SkymanOne
SkymanOne committed Nov 20, 2023
commit 099602e6d42f549df0641c1d533ccc9299969d88
4 changes: 2 additions & 2 deletions crates/ink/tests/return_type_metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ mod tests {
let message = metadata.spec().messages().iter().next().unwrap();
assert_eq!("TraitDefinition::get_value", message.label());

let type_spec = message.return_type().opt_type().unwrap();
let type_spec = message.return_type().ret_type();
let ty = resolve_type(&metadata, type_spec.ty().id);
let (ok_ty, _) = extract_result(&metadata, ty);

Expand All @@ -119,7 +119,7 @@ mod tests {
let constructor = metadata.spec().constructors().iter().next().unwrap();

assert_eq!("try_new", constructor.label());
let type_spec = constructor.return_type().opt_type().unwrap();
let type_spec = constructor.return_type().ret_type();
assert_eq!(
"ink_primitives::ConstructorResult",
format!("{}", type_spec.display_name())
Expand Down