Restore display name for event metadata arg type

[ascjones]

Restore the displayName property of the type of an event argument.

It should have been ported across as part of #1827.

[SkymanOne]

I assume the changes in generator/metadata.rs are purely cosmetic?

[ascjones]

I assume the changes in generator/metadata.rs are purely cosmetic?

Indeed: the code is simply moved to a free function so it can be exported and used in the ink_macro crate.

[cmichi]

Thanks!

[github-actions]

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract	Upstream Size (kB)	PR Size (kB)	Diff (kB)	Diff (%)	Change
basic-contract-caller	3.303	3.303	0	0	➖
basic-contract-caller/other-contract	1.583	1.583	0	0	➖
call-builder-return-value	9.169	9.169	0	0	➖
call-runtime	2.061	2.061	0	0	➖
combined-extension	2.12	2.137	0.017	0.801887	📈
conditional-compilation	1.49	1.49	0	0	➖
contract-storage	7.568	7.568	0	0	➖
contract-terminate	1.329	1.329	0	0	➖
contract-transfer	1.689	1.689	0	0	➖
custom-allocator	7.775	7.775	0	0	➖
custom-environment	2.146	2.146	0	0	➖
dns	7.318	7.318	0	0	➖
e2e-call-runtime	1.296	1.296	0	0	➖
e2e-runtime-only-backend	1.881	1.881	0	0	➖
erc1155	14.237	14.237	0	0	➖
erc20	6.918	6.918	0	0	➖
erc721	9.873	9.873	0	0	➖
events	5.258	5.258	0	0	➖
flipper	1.639	1.639	0	0	➖
incrementer	1.504	1.504	0	0	➖
lang-err-integration-tests/call-builder-delegate	2.638	2.638	0	0	➖
lang-err-integration-tests/call-builder	5.066	5.066	0	0	➖
lang-err-integration-tests/constructors-return-value	1.985	1.985	0	0	➖
lang-err-integration-tests/contract-ref	4.629	4.629	0	0	➖
lang-err-integration-tests/integration-flipper	1.815	1.815	0	0	➖
lazyvec-integration-test	4.616	4.616	0	0	➖
mapping-integration-tests	7.999	7.999	0	0	➖
mother	12.741	12.741	0	0	➖
multi-contract-caller	6.106	6.106	0	0	➖
multi-contract-caller/accumulator	1.378	1.378	0	0	➖
multi-contract-caller/adder	1.968	1.968	0	0	➖
multi-contract-caller/subber	1.988	1.988	0	0	➖
multisig	21.688	21.688	0	0	➖
payment-channel	5.659	5.659	0	0	➖
psp22-extension	7.071	7.071	0	0	➖
rand-extension	2.965	2.965	0	0	➖
sr25519-verification	1.142	1.142	0	0	➖
static-buffer	1.654	1.654	0	0	➖
trait-dyn-cross-contract-calls	2.793	2.793	0	0	➖
trait-dyn-cross-contract-calls/contracts/incrementer	1.545	1.545	0	0	➖
trait-erc20	7.294	7.294	0	0	➖
trait-flipper	1.49	1.49	0	0	➖
trait-incrementer	1.614	1.614	0	0	➖
upgradeable-contracts/delegator	3.151	3.151	0	0	➖
upgradeable-contracts/delegator/delegatee	1.609	1.609	0	0	➖
upgradeable-contracts/set-code-hash-migration	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash-migration/migration	1.45	1.45	0	0	➖
upgradeable-contracts/set-code-hash-migration/updated-incrementer	1.897	1.897	0	0	➖
upgradeable-contracts/set-code-hash	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash/updated-incrementer	1.721	1.721	0	0	➖
wildcard-selector	2.846	2.846	0	0	➖

Link to the run | Last update: Thu Feb 1 11:32:28 CET 2024