Improve docs on transfer() + minimum_balance()#540
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
===========================================
- Coverage 83.15% 68.55% -14.61%
===========================================
Files 155 155
Lines 6811 6811
===========================================
- Hits 5664 4669 -995
- Misses 1147 2142 +995
Continue to review full report at Codecov.
|
Robbepop
approved these changes
Oct 26, 2020
Collaborator
Robbepop
left a comment
There was a problem hiding this comment.
LGTM
Thanks a lot for the docs improvements!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #538 by clearing up the confusion that lead to it.
@athei I think it makes sense to expose a getter for the
subsistence_thresholdfrom seal. Otherwise it's not possible to take this variable into consideration in the smart contract when calculating how much to transfer (like in the issue).(from here)
We already have the
minimum_balance, so it seems consistent to expose the subsistence threshold as well. Wdyt?