Conversation
Robbepop
requested changes
Nov 25, 2020
Robbepop
reviewed
Nov 25, 2020
Co-authored-by: Hero Bird <robin.freyler@gmail.com>
Robbepop
reviewed
Nov 25, 2020
Robbepop
requested changes
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
===========================================
+ Coverage 67.26% 80.07% +12.80%
===========================================
Files 155 156 +1
Lines 6925 6945 +20
===========================================
+ Hits 4658 5561 +903
+ Misses 2267 1384 -883
Continue to review full report at Codecov.
|
Robbepop
reviewed
Nov 27, 2020
Robbepop
reviewed
Dec 2, 2020
Collaborator
Robbepop
left a comment
There was a problem hiding this comment.
All in all looks good to me!
Just some minor fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589.