-
Notifications
You must be signed in to change notification settings - Fork 482
[env] pass salt argument to instantiate host function #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2806e97
WIP
ascjones 0e5b413
Add salt argument to instantiate call
ascjones 2f8b144
Fix lang compilation
ascjones a97be9f
Fix salt to [u8; 4]
ascjones eb4c3e6
Merge branch 'master' into aj-instantiate-salt
ascjones ad2a5cb
Make create builder generic over Salt
ascjones 02e9e80
Use type state instead of ()
ascjones ce76d16
Rename salt to salt_bytes
ascjones f158f2d
Fmt
ascjones a6413d9
Apply review suggestion: type state enum
ascjones a30c139
Apply review suggestion: separate impl block for salt_bytes getter
ascjones 854340a
Apply review suggestion: take salt bytes directly to avoid copy overhead
ascjones a45eca6
Apply review suggestion: use Salt type state instead of leftover conc…
ascjones de5f0c6
Apply review suggestion: fix doc tests
ascjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.