Merged
Conversation
dc9c2c2 to
4ee0738
Compare
4ee0738 to
7e40231
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
===========================================
+ Coverage 67.26% 82.44% +15.18%
===========================================
Files 155 155
Lines 6925 6939 +14
===========================================
+ Hits 4658 5721 +1063
+ Misses 2267 1218 -1049
Continue to review full report at Codecov.
|
Robbepop
requested changes
Dec 2, 2020
Collaborator
Robbepop
left a comment
There was a problem hiding this comment.
All in all nice fix and the impl mostly looks good, however, I really wonder about the BinaryHeap change.
cmichi
commented
Dec 2, 2020
Robbepop
requested changes
Dec 2, 2020
Robbepop
reviewed
Dec 2, 2020
Robbepop
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581.