Merged
Conversation
Hide their docs since they are not meant to be used by ink! users.
xgreenx
reviewed
Nov 1, 2021
| ); | ||
| let result: #message_output = #message_callable(&mut contract, input); | ||
| let failure = ::ink_lang::is_result_type!(#message_output) | ||
| && ::ink_lang::is_result_err!(&result); |
Contributor
There was a problem hiding this comment.
Suggested change
| && ::ink_lang::is_result_err!(&result); | |
| && ::ink_lang::is_result_err!(result); |
Collaborator
Author
There was a problem hiding this comment.
Thank you for the debugging help, @xgreenx !
Contributor
Collaborator
Author
|
On the downside of this PR is that it currently slightly increases the Wasm file sizes of some ink! smart contracts. E.g. ERC-20 raised from 28.9kB to 31.4kB in size. We might be able to find some optimizations to reduce this additional bloat. |
This was referenced Nov 1, 2021
cmichi
approved these changes
Nov 8, 2021
Contributor
I was scratching my head trying to figure out why the ERC-20 on |
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
* add initiate_message and finalize_message utility codegen methods * make is_result_type and is_result_err usable from outside ink_lang Hide their docs since they are not meant to be used by ink! users. * use the new initiate_message and finalize_message in ink! codegen * remove deprecated execute_message utility method * apply rustfmt * fix clippy warnings * prevent Drop call for static storage * add missing docs * fix ui test * fix macro hygiene problem * fix bug * replace some #[inline(always)] with #[inline]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #985.
@xgreenx Please check if this fixes the problems for you.
Not yet optimized. Will do once we know for sure that this fix actually works.