Skip to content

fix: prevent ScreenStackError when stopping agent from modal #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xallam merged 1 commit into from
Mar 20, 2026
+1 −4
Merged

fix: prevent ScreenStackError when stopping agent from modal #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions strix/interface/tui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,9 @@ def on_key(self, event: events.Key) -> None:
event.prevent_default()

def on_button_pressed(self, event: Button.Pressed) -> None:
self.app.pop_screen()
if event.button.id == "stop_agent":
self.app.action_confirm_stop_agent(self.agent_id)
else:
self.app.pop_screen()


class VulnerabilityDetailScreen(ModalScreen): # type: ignore[misc]
Expand Down Expand Up @@ -1912,8 +1911,6 @@ def _validate_agent_for_stopping(self) -> tuple[str, bool]:
return agent_name, False

def action_confirm_stop_agent(self, agent_id: str) -> None:
self.pop_screen()

try:
from strix.tools.agents_graph.agents_graph_actions import stop_agent

Expand Down