Generalized multiphase equilibrium#154
Merged
Merged
Conversation
Generally working! Need to add additional tests after implementing the properties that require ideal-gas part
Seems like entropy specification is working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add routines for general phase multiphase equilibrium, including enthalpy, entropy, internal energy, temperature, pressure and density.
The user is responsible for providing reasonable guess values and so far the iteration is done by the user, but that might be relaxed in future (probably will be).
Closes #148
Closes #142
@longemen3000