Skip to content

hashsum: improve hashsum using 32KiB bufreader #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Oct 20, 2025
Merged

hashsum: improve hashsum using 32KiB bufreader #8869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1876d0d
use 32kb bufreader for hashsum
psvri Oct 10, 2025
53c0102
Address review comment
psvri Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comment
  • Loading branch information
@psvri
psvri committed Oct 11, 2025
commit 53c0102d2e072895fcb7854633974c306c7cc70f
1 change: 1 addition & 0 deletions src/uu/hashsum/src/hashsum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ use uucore::sum::{Digest, Sha3_224, Sha3_256, Sha3_384, Sha3_512, Shake128, Shak
use uucore::translate;

const NAME: &str = "hashsum";
// Using the same read buffer size as GNU
const READ_BUFFER_SIZE: usize = 32 * 1024;
Copy link
Copy Markdown
Contributor

@sylvestre sylvestre Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an comment explaining what is this magic number

(like GNU is fine)

Copy link
Copy Markdown
Contributor Author

@psvri psvri Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


struct Options<'a> {
Expand Down
Loading