Build circuitpython-ulab as part of CI #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircuitPython doc build fails with this diagnostic: ``` /home/runner/work/circuitpython/circuitpython/shared-bindings/ulab/index.rst:220:'any' reference target not found: List[float] ``` Use double backticks instead of single backticks to differentiate between a reference to a type and just "show in monospace font".
jepler
force-pushed
the
ci-circuitpython
branch
4 times, most recently
from
7f57212 to
6fe42a3
Compare
This will check - that the unix port builds and passes its tests - that the doc build succeeds
jepler
force-pushed
the
ci-circuitpython
branch
from
6fe42a3 to
57ab95c
Compare
|
Hopefully this helps with maintaining CircuitPython compatibility! |
|
@jepler Thanks! In cases like this, you should really go ahead, and merge the PR. I am absolutely OK with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #185 so we can hopefully see if the problem is truly resolved.