Skip to content

Conversation

@RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Nov 19, 2021

New branch needs to be created and PR needs to be retargeted.

Example build is here: https://micropython-ulab-robert.readthedocs.io/en/1.7.9/

Relates to #443

@RobertoRoos RobertoRoos changed the title Adding branch release/v1.7 to suit version 1.7.9 Adding branch release/v1.7 to suit version 1.7.9 (WIP) Nov 19, 2021
@RobertoRoos
Copy link
Contributor Author

Hm, the RTD build is failing with

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/micropython-ulab-robert/envs/release-v1.7/lib/python3.7/site-packages/sphinx/cmd/build.py", line 279, in build_main
    args.tags, args.verbosity, args.jobs, args.keep_going)
  File "/home/docs/checkouts/readthedocs.org/user_builds/micropython-ulab-robert/envs/release-v1.7/lib/python3.7/site-packages/sphinx/application.py", line 270, in __init__
    self._init_builder()
  File "/home/docs/checkouts/readthedocs.org/user_builds/micropython-ulab-robert/envs/release-v1.7/lib/python3.7/site-packages/sphinx/application.py", line 329, in _init_builder
    self.events.emit('builder-inited')
  File "/home/docs/checkouts/readthedocs.org/user_builds/micropython-ulab-robert/envs/release-v1.7/lib/python3.7/site-packages/sphinx/events.py", line 110, in emit
    (listener.handler, name), exc, modname=modname) from exc
sphinx.errors.ExtensionError: Handler <function run_autoapi at 0x7fa33ee830e0> for event 'builder-inited' threw an exception (exception: max() arg is an empty sequence)

Extension error (autoapi.extension):
Handler <function run_autoapi at 0x7fa33ee830e0> for event 'builder-inited' threw an exception (exception: max() arg is an empty sequence)

No clue what's wrong here.

@RobertoRoos RobertoRoos changed the title Adding branch release/v1.7 to suit version 1.7.9 (WIP) Adding branch release/v1.7 to suit version 1.7.9 Nov 19, 2021
@RobertoRoos
Copy link
Contributor Author

I updated with the latest conf.py and now it builds. I have to admit I haven't looked at the built output in detail, I just assume the output fails or is correct.

@v923z v923z merged commit 0d13309 into v923z:legacy Nov 19, 2021
@RobertoRoos
Copy link
Contributor Author

RobertoRoos commented Nov 19, 2021

Nonono, this isn't supposed to go into the legacy branch. All these versions should have their own branch, but I don't have the power to create branches here.

Can you force push this merge out? And then retarget this PR?

EDIT: Never mind, I just realized v1.7 was already in this branch.

@v923z
Copy link
Owner

v923z commented Nov 19, 2021

@RobertoRoos I think 1.7.9 is OK here, because 1.7.8 was at the end of the legacy branch. So, in that case, we can continue there in a linear fashion.
On the other hand, 0.36, and 0.54.4 should have their own branches, which I created.

EDIT: I am still baffled by why you need documentation for a badly outdated version.

@RobertoRoos
Copy link
Contributor Author

@v923z yeah I see now. Thanks for merging!

Yeah, I'm having my doubts about those versions now 😅
Funny thing is we now have the ticket to also update our plan version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants