replace m_new with m_new0, wherever reasonable #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Apr 19, 2022
code/ndarray.c
Outdated
| size_t *coords = m_new0(size_t, ndim); | ||
| #if !MICROPY_GC_CONSERVATIVE_CLEAR | ||
| memset(coords, 0, ndim*sizeof(size_t)); | ||
| #endif |
There was a problem hiding this comment.
You don't need to use both m_new9 and MICROPY_GC_CONSERVATIVE_CLEAR. You can select one of these options:
size_t *coords = m_new0(size_t, ndim);or:
size_t *coords = m_new(size_t, ndim);
#if !MICROPY_GC_CONSERVATIVE_CLEAR
memset(coords, 0, ndim*sizeof(size_t));
#endifHave a look at the source code of m_malloc0 to understand better.
The first option (just call m_new0) is much simpler and I suggest to do that. The API of m_new0 is unlikely to change. But the macro MICROPY_GC_CONSERVATIVE_CLEAR may one day be removed.
There was a problem hiding this comment.
I have obviously tanked it completely. Thanks for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised in #520