fix(unescape-bug): Fixed bug where intermediate string contains escaped characters #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2038 +9
Branches 457 460 +3
=========================================
+ Hits 2029 2038 +9
Continue to review full report at Codecov.
|
fedeci
previously approved these changes
Oct 29, 2021
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
…haracters (validatorjs#1835) * Fixed bug where intermediate string contains escaped characters * Added reference to issue Co-authored-by: Markus Tyrkkö <[email protected]> Co-authored-by: Markus <[email protected]>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
…haracters (#1835) * Fixed bug where intermediate string contains escaped characters * Added reference to issue Co-authored-by: Markus Tyrkkö <[email protected]> Co-authored-by: Markus <[email protected]>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
…haracters (#1835) * Fixed bug where intermediate string contains escaped characters * Added reference to issue Co-authored-by: Markus Tyrkkö <[email protected]> Co-authored-by: Markus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1827
If the intermediate string contains escape sequences, eg. unescaping
&lt;resulted in incorrect output<. Moved & unescape as last operation to handle all other sequences before that.Checklist