fix for isMobilePhone pt-BR locale #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regex for pt-BR, now accepting number 1 after number 9 for mobile phone numbers
valid and invalid test values updated due fix on isMobilePhone.js for pt-BR
Codecov Report
@@ Coverage Diff @@
## master #1964 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2120 2120
Branches 475 475
=========================================
Hits 2120 2120 Continue to review full report at Codecov.
|
rubiin
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(isMobilePhone): pt-BR locale
correct regex for pt-br phone numbers
changed tests for pt-BR mobile phone number validation
Removed valid number from invalid list of pt-br phones
Numbers with 9 digits, second digit being 1-9
Updated tests to check on pt-br phone numbers starting with 9 and followed by 1-9
Updated tests to comply with new phone numbers