Skip to content

validation for Pakistan's passport #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

validation for Pakistan's passport #2073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d88f1a
included Philippines in passportRegexByCountryCode
Oct 12, 2022
ea6dda1
added tests for Philippines in passport-validation & also added it's …
Oct 12, 2022
97ef961
fixed issues prompted by node
Oct 12, 2022
d1d4ec7
added passport validation for Pakistan
digambar-t7 Oct 16, 2022
c44d0d7
Merge branch 'master' into pakPassport
digambar-t7 Oct 18, 2022
6efd3b1
followed the ISO 3166-1 alpha-2 standards for countryCodes PAK & PHL
digambar-t7 Oct 18, 2022
3e0f895
just merging fetched changes
digambar-t7 Oct 18, 2022
a6ea7ef
changed PAK->PK & PHL->PH
digambar-t7 Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed issues prompted by node
  • Loading branch information
Digambar Tupurwadi committed Oct 12, 2022
commit 97ef9610e47174051bc9a6054fd42b9487dbfb9c
2 changes: 1 addition & 1 deletion src/lib/isPassportNumber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const passportRegexByCountryCode = {
MY: /^[AHK]\d{8}$/, // MALAYSIA
MX: /^\d{10,11}$/, // MEXICO
NL: /^[A-Z]{2}[A-Z0-9]{6}\d$/, // NETHERLANDS
PHL: /^([A-Z](\d{6}|\d{7}[A-Z]))|([A-Z]{2}(\d{6}|\d{7}))$/, //PHILIPPINES
PHL: /^([A-Z](\d{6}|\d{7}[A-Z]))|([A-Z]{2}(\d{6}|\d{7}))$/, // PHILIPPINES
PL: /^[A-Z]{2}\d{7}$/, // POLAND
PT: /^[A-Z]\d{6}$/, // PORTUGAL
RO: /^\d{8,9}$/, // ROMANIA
Expand Down
4 changes: 2 additions & 2 deletions test/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3287,12 +3287,12 @@ describe('Validators', () => {
'X123456',
'XY123456',
'XY1234567',
'X1234567Y'
'X1234567Y',
],
invalid: [
'XY12345',
'X12345Z',
'XY12345Z'
'XY12345Z',
],
});

Expand Down