Skip to content

isEmail: do not allow non-breaking space in user part #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2023
Merged

isEmail: do not allow non-breaking space in user part #2237

merged 1 commit into from
Jun 26, 2023

Conversation

@jeremy21212121
Copy link
Contributor

bug(isEmail) Do not allow non-breaking space in user part

Fixes #2218

  • Excluded non-breaking space character from range of acceptable UTF8 characters in the user part of email address

  • Added test cases to confirm fix

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@jeremy21212121 jeremy21212121 mentioned this pull request Jun 22, 2023
Closed
@rubiin rubiin requested review from WikiRik and profnandaa June 25, 2023 19:28
profnandaa
profnandaa approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@profnandaa profnandaa merged commit 63b1e4d into validatorjs:master Jun 26, 2023
@profnandaa profnandaa mentioned this pull request Aug 3, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@kaifkh20 kaifkh20 mentioned this pull request May 30, 2024
Open
@Safar123 Safar123 mentioned this pull request May 30, 2024
Open
@IT21149412 IT21149412 mentioned this pull request May 30, 2024
Open
@Achmad-Farid Achmad-Farid mentioned this pull request May 30, 2024
Open
@ahmetilboga2004 ahmetilboga2004 mentioned this pull request May 30, 2024
Merged
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@TuanNB28 TuanNB28 mentioned this pull request May 30, 2024
Open
@StemmlerSisters StemmlerSisters mentioned this pull request May 30, 2024
Open
@peterboni peterboni mentioned this pull request May 30, 2024
Open
@rntvicente rntvicente mentioned this pull request May 30, 2024
Open
@DefenderK DefenderK mentioned this pull request May 30, 2024
Closed
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 30, 2024
Open
@saileshbro saileshbro mentioned this pull request May 30, 2024
Merged
@malforsaja malforsaja mentioned this pull request May 30, 2024
Merged
@ryanlelek ryanlelek mentioned this pull request May 30, 2024
Closed
@ziccardi ziccardi mentioned this pull request May 30, 2024
Open
@MoTarigOs MoTarigOs mentioned this pull request May 30, 2024
Open
@pasang7 pasang7 mentioned this pull request May 30, 2024
Open
@Coteh Coteh mentioned this pull request Jul 17, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
@vky5 vky5 mentioned this pull request Jul 30, 2024
Closed
@Playgirlkaybraz11 Playgirlkaybraz11 mentioned this pull request Aug 12, 2024
Open
@luizhp luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@TheJ-Erk400 TheJ-Erk400 mentioned this pull request Sep 7, 2024
Open
@sumandas0 sumandas0 mentioned this pull request Sep 8, 2024
Open
@TheJ-Erk400 TheJ-Erk400 mentioned this pull request Sep 8, 2024
Open
@Bastien-Durand Bastien-Durand mentioned this pull request Sep 9, 2024
Open
@kaifkh20 kaifkh20 mentioned this pull request Sep 9, 2024
Merged
This was referenced Sep 10, 2024
Open
Open
@harish845 harish845 mentioned this pull request Sep 13, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 14, 2024
Open
@harish845 harish845 mentioned this pull request Sep 14, 2024
Open
@vky5 vky5 mentioned this pull request Sep 15, 2024
Closed
@amay0808 amay0808 mentioned this pull request Sep 16, 2024
Open
@IT21269134 IT21269134 mentioned this pull request Sep 17, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 18, 2024
Open
@ch4mi2 ch4mi2 mentioned this pull request Sep 19, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 19, 2024
Open
@pasanchamikara99 pasanchamikara99 mentioned this pull request Sep 26, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
@DefenderK DefenderK mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Non breaking space bypass email validation

5 participants

@jeremy21212121 @profnandaa @rubiin @WikiRik @mm-jpoole