Skip to content

Conversation

@BibhushanKarki
Copy link
Contributor

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have preferred adding "either of the following"?

@rubiin rubiin merged commit 806e55e into validatorjs:master Jun 1, 2024
@rubiin
Copy link
Member

rubiin commented Jun 1, 2024

I will be merging this for now

@profnandaa
Copy link
Member

@rubiin -- can be squash-merging instead, there should be that option on your end?

@rubiin
Copy link
Member

rubiin commented Jun 1, 2024

yeah but figured that would be an issue as the pr has single commit

@profnandaa
Copy link
Member

I meant this one:
image

it the preferred approach to, "Merge pull request ..." commit messages....

@rubiin
Copy link
Member

rubiin commented Jun 3, 2024

oh gotcha

1 similar comment
@rubiin
Copy link
Member

rubiin commented Jun 3, 2024

oh gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants