Skip to content

test(testFunctions): display stringified arguments in error message #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2024
Merged

test(testFunctions): display stringified arguments in error message #2442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(testFunctions): display stringified arguments in error message 
this now shows the actual passed arguments,
instead of [Object object] in case a test with a options object fails
  • Loading branch information
@pano9000
pano9000 committed Aug 25, 2024
commit e9a2f9455f9c3e63d7a05c22ce5f2b85cb02487d
10 changes: 7 additions & 3 deletions test/testFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import assert from 'assert';
import { format } from 'util';
import validator from '../src/index';

function stringifyArgs(argsArr) {
return argsArr.map(arg => JSON.stringify(arg)).join(', ');
}

export default function test(options) {
const args = options.args || [];

Expand All @@ -16,7 +20,7 @@ export default function test(options) {
} catch (err) {
const warning = format(
'validator.%s(%s) passed but should error',
options.validator, args.join(', ')
options.validator, stringifyArgs(args)
);

throw new Error(warning);
Expand All @@ -31,7 +35,7 @@ export default function test(options) {
if (validator[options.validator](...args) !== true) {
const warning = format(
'validator.%s(%s) failed but should have passed',
options.validator, args.join(', ')
options.validator, stringifyArgs(args)
);

throw new Error(warning);
Expand All @@ -46,7 +50,7 @@ export default function test(options) {
if (validator[options.validator](...args) !== false) {
const warning = format(
'validator.%s(%s) passed but should have failed',
options.validator, args.join(', ')
options.validator, stringifyArgs(args)
);

throw new Error(warning);
Expand Down