Skip to content

refactor: make brazilian postal code separator optional #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

refactor: make brazilian postal code separator optional #2493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5c339
refactor: make brazilian postal code separator optional
ticmaisdev Nov 12, 2024
39ec296
feat(br postal code): test valid input where separator is omitted
ticmaisdev Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: make brazilian postal code separator optional 
separator is supposed to be at presentation layer (formatting). making it required forces applications to store uncessary data.
  • Loading branch information
@ticmaisdev
ticmaisdev authored Nov 12, 2024
commit 3c5c3396ca3cd541afa33f3422dc539f48286641
2 changes: 1 addition & 1 deletion src/lib/isPostalCode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const patterns = {
BA: /^([7-8]\d{4}$)/,
BE: fourDigit,
BG: fourDigit,
BR: /^\d{5}-\d{3}$/,
BR: /^\d{5}-?\d{3}$/,
BY: /^2[1-4]\d{4}$/,
CA: /^[ABCEGHJKLMNPRSTVXY]\d[ABCEGHJ-NPRSTV-Z][\s\-]?\d[ABCEGHJ-NPRSTV-Z]\d$/i,
CH: fourDigit,
Expand Down
Loading