Skip to content

feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number #2500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa5a410
feat: Validation for macedonian phone number added
eshward95 Nov 21, 2024
ccd4647
fix:refined regex for all mk numbers
eshward95 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix:refined regex for all mk numbers
  • Loading branch information
@eshward95
eshward95 committed Nov 21, 2024
commit ccd46476cf5de3265e012dd2c223e6f5666eb13f
2 changes: 1 addition & 1 deletion src/lib/isMobilePhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const phones = {
'ar-YE': /^(((\+|00)9677|0?7)[0137]\d{7}|((\+|00)967|0)[1-7]\d{6})$/,
'ar-EH': /^(\+?212|0)[\s\-]?(5288|5289)[\s\-]?\d{5}$/,
'fa-AF': /^(\+93|0)?(2{1}[0-8]{1}|[3-5]{1}[0-4]{1})(\d{7})$/,
'mk-MK': /^(\+?389|0)?[2-8]\d{7}$/,
'mk-MK': /^(\+?389|0)?((?:2[2-9]\d{6}|(?:3[1-4]|4[2-8])\d{6}|500\d{5}|5[2-9]\d{6}|7[0-9][2-9]\d{5}|8[1-9]\d{6}|800\d{5}|8009\d{4}))$/,
};
/* eslint-enable max-len */

Expand Down
15 changes: 10 additions & 5 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10733,24 +10733,29 @@ describe('Validators', () => {
{
locale: 'mk-MK',
valid: [
'+38921234567',
'+38971234567',
'+38923234567',
'38931234567',
'38961234567',
'21234567',
'022123456',
'22234567',
'71234567',
'31234567',
'+38923091500',
'80091234',
'81123456',
'54123456',
],
invalid: [
'38912345678',
'+389123456789',
'2123456',
'21234567',
'123456789',
'+3891234567',
'700012345',
'510123456',
'This should fail',
'+389123456',
'389123456',
'80912345',
],
},
];
Expand Down
Loading