Skip to content

Conversation

@WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 28, 2025

Updates the versions used in CI. Also fixes the npm-publish workflow. In draft until #2538 is merged, so we can check that the upload to codecov works

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@WikiRik WikiRik force-pushed the WikiRik/update-ci branch from 4ed17f6 to 8d6dc48 Compare March 28, 2025 21:48
@WikiRik WikiRik marked this pull request as draft March 28, 2025 21:49
@WikiRik WikiRik marked this pull request as ready for review April 8, 2025 15:10
@WikiRik
Copy link
Member Author

WikiRik commented Apr 8, 2025

This has more priority since ubuntu-20.04 runners will be removed next week. See the following message that we got on the recent merge to master;
This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see https://github.com/actions/runner-images/issues/11101

@WikiRik WikiRik marked this pull request as draft April 8, 2025 15:13
@WikiRik
Copy link
Member Author

WikiRik commented Apr 8, 2025

@profnandaa can you add the CODECOV_TOKEN to the repo secrets? The secret can be found here; https://app.codecov.io/github/validatorjs/validator.js/config/general and if needed some explanation on how to set a repository secret in GitHub; https://docs.codecov.com/docs/codecov-tokens#example-github-actions--official-codecov-action

@profnandaa
Copy link
Member

Sure, done.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (f81d857) to head (8b0bec3).
Report is 37 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2539      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          110      113       +3     
  Lines         2510     2527      +17     
  Branches       633      641       +8     
===========================================
+ Hits          2510     2526      +16     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik WikiRik marked this pull request as ready for review April 8, 2025 15:52
@WikiRik
Copy link
Member Author

WikiRik commented Apr 8, 2025

I'll take care of codecov in #2549 as it's unrelated to these changes

@WikiRik WikiRik merged commit 991e5ac into master Apr 8, 2025
21 of 22 checks passed
@WikiRik WikiRik deleted the WikiRik/update-ci branch April 8, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants