Skip to content

add ukranian number regex #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add ukranian number regex #581

wants to merge 1 commit into from

Conversation

foozzi
Copy link

@foozzi foozzi commented Sep 18, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.12% when pulling 911b65d on foozzi:master into 3443132 on chriso:master.

chriso
chriso requested changes Sep 25, 2016
View reviewed changes
Copy link
Collaborator

@chriso chriso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update src/lib/isMobilePhone.js. This file is compiled output from babel. You'll also need to update the README and add a test case.

@chriso
Copy link
Collaborator

chriso commented Sep 27, 2016

Please submit another PR with the required changes.

@chriso chriso closed this Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chriso chriso chriso requested changes

+1 more reviewer

@IOAyman IOAyman IOAyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@foozzi @coveralls @chriso @IOAyman