Skip to content

fix: amend customercases preview component, use initial data from server and fetch live data from client #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinbaxon merged 3 commits into from
Nov 26, 2025
Merged

fix: amend customercases preview component, use initial data from server and fetch live data from client #1475

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66ba73c
fix: make pageBuilder more defensive when loading titles and slugs
robinbaxon Nov 17, 2025
f2797cc
fix(bug): for preview, query initial customercases data server side, …
robinbaxon Nov 17, 2025
906b925
fix: make customerCases have presedence, will default to dynamicpage …
robinbaxon Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: make pageBuilder more defensive when loading titles and slugs
  • Loading branch information
@robinbaxon
robinbaxon committed Nov 26, 2025
commit 66ba73c186ac5f3a8f2f434d2ab3a2289479318b
23 changes: 11 additions & 12 deletions studio/schemas/documents/pageBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,19 +89,18 @@ const pageBuilder = defineType({
slug: titleSlug.name,
},
prepare({ title, slug }) {
if (!isInternationalizedString(title)) {
throw new TypeError(
`Expected 'title' to be InternationalizedString, was ${typeof title}`,
);
}
if (!isInternationalizedString(slug)) {
throw new TypeError(
`Expected 'slug' to be InternationalizedString, was ${typeof slug}`,
);
}
// Handle cases where the field might not be properly initialized yet
const titleText = isInternationalizedString(title)
? (firstTranslation(title) ?? undefined)
: undefined;

const slugText = isInternationalizedString(slug)
? (firstTranslation(slug) ?? undefined)
: undefined;

return {
title: firstTranslation(title) ?? undefined,
subtitle: firstTranslation(slug) ?? undefined,
title: titleText || "Untitled",
subtitle: slugText,
};
},
},
Expand Down