Skip to content

Conversation

@cruisediary
Copy link
Contributor

@cruisediary cruisediary commented Aug 25, 2018

Given func testDateValidation() does not cover after target date because it's same to target date

let targetDate = "2018-05-29T12:00+09:00".date(format: .iso8601Auto)!.absoluteDate
let afterTargetDate = "2018-05-29T12:00+09:00".date(format: .iso8601Auto)!.absoluteDate
  • Add unit test for after target date and fix failed test case
  • Add unit test for same target date when validate with .shouldBeforeThen or .shouldAfterThen fix failed test case

related links
https://developer.apple.com/documentation/foundation/comparisonresult

Constants
case orderedAscending
The left operand is smaller than the right operand.

case orderedSame
The two operands are equal.

case orderedDescending
The left operand is greater than the right operand.

@vbmania vbmania self-requested a review August 26, 2018 11:20
@vbmania
Copy link
Owner

vbmania commented Aug 26, 2018

Thank you for your HELP! ^^
I will review and approve pull-request as soon as possible.

역시 크루 짱!

@vbmania vbmania merged commit ddee353 into vbmania:develop Aug 28, 2018
@vbmania
Copy link
Owner

vbmania commented Aug 28, 2018

날짜 계산하면서 겁나 헷갈렸는데 감사합니다 ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants