fix: upgrade @modelcontextprotocol/sdk to v1.17.2 for critical transport handling fix #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing fix Upgrades the MCP SDK to version 1.17.2 which includes a critical fix for transport handling in multi-client scenarios. The previous SDK version had a bug where the Protocol class would overwrite its transport reference, causing responses to be sent to the wrong client when multiple clients were connected. This was particularly problematic for StreamableHTTP transport in production environments. The fix ensures that each request maintains its proper transport context through closure capture, guaranteeing responses are sent to the correct client. All existing tests pass with the new version, confirming compatibility. Related: modelcontextprotocol/typescript-sdk#820
|
this is great! cc @allenzhou101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@modelcontextprotocol/sdkpeer dependency to v1.17.2 to incorporate a critical bug fix for transport handling in multi-client scenarios.Problem
The previous SDK version (^1.12.0) contained a bug where the Protocol class would overwrite its internal transport reference when handling concurrent requests from multiple clients. This caused responses to be incorrectly routed to the wrong client connection.
This issue particularly affected production deployments using StreamableHTTP transport where multiple clients connect to the same server instance.
Solution
The SDK v1.17.2 includes the fix from modelcontextprotocol/typescript-sdk#820 which ensures proper transport context isolation by capturing the transport reference at request time through closure.
Compatibility
✅ No breaking changes affecting mcp-adapter
Impact
Testing
Related Issues