Skip to content

fix standalone wrong url being logged #44887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 16, 2023
Merged

fix standalone wrong url being logged #44887

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c874f1f
fix(standalone): log correct url for running server
IgnisDa Jan 14, 2023
c01c8bc
update format and add test
ijjk Jan 16, 2023
e5216fd
update
ijjk Jan 16, 2023
d63cbd8
Merge branch 'canary' into canary
ijjk Jan 16, 2023
800260e
Merge branch 'canary' into canary
kodiakhq[bot] Jan 16, 2023
1c1b2f8
update test
ijjk Jan 16, 2023
8b418bd
test
ijjk Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update format and add test
  • Loading branch information
@ijjk
ijjk committed Jan 16, 2023
commit c01c8bc0ab75a5ecee9e264761e9afbdadbd2fdb
2 changes: 1 addition & 1 deletion packages/next/src/build/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1789,7 +1789,7 @@ server.listen(currentPort, (err) => {
console.log(
'Listening on port',
currentPort,
'url:', hostname + ':' + currentPort
'url: http://' hostname + ':' + currentPort
)
})`
)
Expand Down
12 changes: 12 additions & 0 deletions test/production/standalone-mode/response-cache/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe('minimal-mode-response-cache', () => {
let next: NextInstance
let server
let appPort
let output = ''

beforeAll(async () => {
// test build against environment with next support
Expand Down Expand Up @@ -64,6 +65,12 @@ describe('minimal-mode-response-cache', () => {
undefined,
{
cwd: next.testDir,
onStdout(msg) {
output += msg
},
onStderr(msg) {
output += msg
},
}
)
})
Expand All @@ -72,6 +79,11 @@ describe('minimal-mode-response-cache', () => {
if (server) await killApp(server)
})

it('should have correct "Listening on" log', async () => {
expect(output).toContain(`Listening on port`)
expect(output).toContain(`url: http://localhost:${appPort}`)
})

it('should have correct responses', async () => {
const html = await renderViaHTTP(appPort, '/')
expect(html.length).toBeTruthy()
Expand Down