Skip to content

fix: add missing <preload> for next/image in App Router #52425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 9 commits into from
Jul 14, 2023
Merged

fix: add missing <preload> for next/image in App Router #52425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bb27851
fix: add missing `<preload>` for `next/image` in App Router
styfle Jul 8, 2023
c8475e0
Update tests
styfle Jul 10, 2023
390d566
Fix `crossorigin` tests
styfle Jul 10, 2023
7b46bbc
Merge branch 'canary' into styfle/next-846-nextimage-preload-is-not-w…
styfle Jul 13, 2023
f72c9d0
Remove `it.only()`
styfle Jul 13, 2023
d3c3b55
Fix unit test
styfle Jul 14, 2023
213d3b0
Fix camelCase referrerPolicy
styfle Jul 14, 2023
882050b
Only expect error on preload opts
styfle Jul 14, 2023
7d57784
Merge branch 'canary' into styfle/next-846-nextimage-preload-is-not-w…
styfle Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests
  • Loading branch information
@styfle
styfle committed Jul 10, 2023
commit c8475e0f0260ef031c1328a4d9f27782c40e6c79
2 changes: 1 addition & 1 deletion test/integration/next-image-new/app-dir/app/priority/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Page = () => {
priority
id="basic-image-crossorigin"
alt="basic-image-crossorigin"
src="/test.jpg"
src="/test.webp"
width="400"
height="400"
crossOrigin="anonymous"
Expand Down
4 changes: 2 additions & 2 deletions test/integration/next-image-new/app-dir/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,13 @@ function runTests(mode) {
entries.find(
(item) =>
item.imagesrcset ===
'/_next/image?url=%2Ftest.jpg&w=640&q=75 1x, /_next/image?url=%2Ftest.jpg&w=828&q=75 2x'
'/_next/image?url=%2Ftest.webp&w=640&q=75 1x, /_next/image?url=%2Ftest.webp&w=828&q=75 2x'
)
).toEqual({
fetchpriority: 'high',
imagesizes: '',
imagesrcset:
'/_next/image?url=%2Ftest.jpg&w=640&q=75 1x, /_next/image?url=%2Ftest.jpg&w=828&q=75 2x',
'/_next/image?url=%2Ftest.webp&w=640&q=75 1x, /_next/image?url=%2Ftest.webp&w=828&q=75 2x',
crossorigin: 'anonymous',
referrerPolicy: '',
})
Expand Down
2 changes: 1 addition & 1 deletion test/integration/next-image-new/default/pages/priority.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Page = () => {
priority
id="basic-image-crossorigin"
alt="basic-image-crossorigin"
src="/test.jpg"
src="/test.webp"
width="400"
height="400"
crossOrigin="anonymous"
Expand Down
4 changes: 2 additions & 2 deletions test/integration/next-image-new/default/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,13 @@ function runTests(mode) {
entries.find(
(item) =>
item.imagesrcset ===
'/_next/image?url=%2Ftest.jpg&w=640&q=75 1x, /_next/image?url=%2Ftest.jpg&w=828&q=75 2x'
'/_next/image?url=%2Ftest.webp&w=640&q=75 1x, /_next/image?url=%2Ftest.webp&w=828&q=75 2x'
)
).toEqual({
fetchpriority: 'high',
imagesizes: '',
imagesrcset:
'/_next/image?url=%2Ftest.jpg&w=640&q=75 1x, /_next/image?url=%2Ftest.jpg&w=828&q=75 2x',
'/_next/image?url=%2Ftest.webp&w=640&q=75 1x, /_next/image?url=%2Ftest.webp&w=828&q=75 2x',
crossorigin: 'anonymous',
referrerPolicy: '',
})
Expand Down