Skip to content

chore: safety check on lockfile patching #66448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: safety check on lockfile patching #66448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/next/src/lib/patch-incorrect-lockfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ async function fetchPkgInfo(pkg: string) {
const data = await res.json()
const versionData = data.versions[nextPkgJson.version]

if (!versionData) {
return null
}

return {
os: versionData.os,
cpu: versionData.cpu,
Expand Down Expand Up @@ -60,7 +64,7 @@ export async function patchIncorrectLockfile(dir: string) {

const patchDependency = (
pkg: string,
pkgData: UnwrapPromise<ReturnType<typeof fetchPkgInfo>>
pkgData: NonNullable<UnwrapPromise<ReturnType<typeof fetchPkgInfo>>>
) => {
lockfileParsed.dependencies[pkg] = {
version: nextPkgJson.version,
Expand All @@ -72,7 +76,7 @@ export async function patchIncorrectLockfile(dir: string) {

const patchPackage = (
pkg: string,
pkgData: UnwrapPromise<ReturnType<typeof fetchPkgInfo>>
pkgData: NonNullable<UnwrapPromise<ReturnType<typeof fetchPkgInfo>>>
) => {
lockfileParsed.packages[pkg] = {
version: nextPkgJson.version,
Expand Down Expand Up @@ -151,6 +155,11 @@ export async function patchIncorrectLockfile(dir: string) {
const pkg = missingSwcPkgs[i]
const pkgData = pkgsData[i]

if (!pkgData) {
Log.warn(`Failed to fetch registry info for ${pkg}`)
continue
}

if (shouldPatchDependencies) {
patchDependency(pkg, pkgData)
}
Expand Down