Skip to content

fix: normalize-asset-prefix adding leading slash when URL assetPrefix is provided #68518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix: normalize-asset-prefix adding leading slash when URL assetPrefix is provided #68518

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc1088a
test: add test for normalized-asset-prefix (#68519)
devjiwonchoi Aug 5, 2024
38d17da
fix: normalize asset prefix for socket if start with http
devjiwonchoi Aug 5, 2024
240f468
test: normalize-asset-prefix should return url if is url
devjiwonchoi Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: normalize-asset-prefix should return url if is url
  • Loading branch information
@devjiwonchoi
devjiwonchoi committed Aug 6, 2024
commit 240f468e52b004436d94f8bedbf67868a8cdabe6
17 changes: 11 additions & 6 deletions packages/next/src/shared/lib/normalized-asset-prefix.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,19 @@ describe('normalizedAssetPrefix', () => {
expect(normalizedAssetPrefix('path/to/asset')).toBe('/path/to/asset')
})

it('should return a URL without protocol when assetPrefix is a URL', () => {
// TODO: this is for comparison, remove this before PR merge
expect(normalizedAssetPrefix('https://example.com/path/to/asset')).not.toBe(
'/https://example.com/path/to/asset'
)
it('should remove all trailing slash(es) when assetPrefix has one', () => {
expect(normalizedAssetPrefix('/path/to/asset///')).toBe('/path/to/asset')
})

it('should return the URL when assetPrefix is a URL', () => {
expect(normalizedAssetPrefix('https://example.com/path/to/asset')).toBe(
'example.com/path/to/asset'
'https://example.com/path/to/asset'
)
})

it('should not leave a trailing slash when assetPrefix is a URL with no pathname', () => {
expect(normalizedAssetPrefix('https://example.com')).toBe(
'https://example.com'
)
})
})