Skip to content

[turbopack] Make it possible to synchronously access native bindings #85787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukesandberg merged 10 commits into from
Nov 8, 2025
Merged

[turbopack] Make it possible to synchronously access native bindings #85787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
04cdd27
make installing native bindings more regular to allow more usecases t…
lukesandberg Nov 5, 2025
51d9d57
install bindings in build workers
lukesandberg Nov 7, 2025
9725bbd
fix a test set up
lukesandberg Nov 7, 2025
4bfe942
install bindings after initializing telemetry
lukesandberg Nov 7, 2025
4fc7835
move install-bindings to its own file to ensure we don't load it befo…
lukesandberg Nov 7, 2025
ed238b2
don't install in the router server
lukesandberg Nov 7, 2025
a4ebdf5
revert a nit
lukesandberg Nov 7, 2025
2853847
fix two test issues
lukesandberg Nov 7, 2025
6317a0b
handle dev bundler
lukesandberg Nov 7, 2025
bedbeb6
another test setup
lukesandberg Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix two test issues
  • Loading branch information
@lukesandberg
lukesandberg committed Nov 7, 2025
commit 2853847f2f6ab66a5ece4e8a38a04fab2ca8bbea
2 changes: 1 addition & 1 deletion packages/next/src/server/patch-error-inspect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ function parseAndSourceMap(
inspectOptions: util.InspectOptions
): string {
// TODO(veil): Expose as CLI arg or config option. Useful for local debugging.
const showIgnoreListed = true
const showIgnoreListed = false
// We overwrote Error.prepareStackTrace earlier so error.stack is not sourcemapped.
let unparsedStack = String(error.stack)
// We could just read it from `error.stack`.
Expand Down
3 changes: 2 additions & 1 deletion test/unit/next-swc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-env jest */
import { installBindings, transform } from 'next/dist/build/swc'
import { transform } from 'next/dist/build/swc'
import { installBindings } from 'next/dist/build/swc/install-bindings'
import path from 'path'
import fsp from 'fs/promises'

Expand Down