Skip to content

[feat] add validation shuffle#1886

Merged
vermouth1992 merged 3 commits intoverl-project:mainfrom
0x0C001:feat/add-validation_shuffle
Jun 7, 2025
Merged

[feat] add validation shuffle#1886
vermouth1992 merged 3 commits intoverl-project:mainfrom
0x0C001:feat/add-validation_shuffle

Conversation

@0x0C001
Copy link
Contributor

@0x0C001 0x0C001 commented Jun 6, 2025

Checklist Before Starting

  • Search for similar PR(s).

What does this PR do?

In scenarios involving multiple validation sets, where the difficulty levels of these sets differ significantly and the generated content lengths vary notably, the order in which the validation sets are processed can have a substantial impact on the validation speed.

High-Level Design

add validation shuffle

Usage Example

Provide usage example(s) for easier usage.

validation_shuffle: True

Test

Validation speed increase of over 10%.

Checklist Before Submitting

  • Read the Contribute Guide.
  • Apply pre-commit checks.
  • Add [BREAKING] to the PR title if it breaks any API.
  • Update the documentation about your changes in the docs.
  • New CI unit test(s) are added to cover the code path.
  • Rely on existing unit tests on CI that covers the code path.

return_raw_chat: False
return_full_prompt: False
shuffle: True
validation_shuffle: True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we not modify the default behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@vermouth1992 vermouth1992 merged commit 01fee0a into verl-project:main Jun 7, 2025
1 check passed
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Jun 10, 2025
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

In scenarios involving multiple validation sets, where the difficulty
levels of these sets differ significantly and the generated content
lengths vary notably, the order in which the validation sets are
processed can have a substantial impact on the validation speed.

### High-Level Design

add validation shuffle

### Usage Example

> Provide usage example(s) for easier usage.

```python
validation_shuffle: True
```

### Test

Validation speed increase of over 10%.

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [ ] Add `[BREAKING]` to the PR title if it breaks any API.
- [ ] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [ ] New CI unit test(s) are added to cover the code path.
- [ ] Rely on existing unit tests on CI that covers the code path.
whatadayG pushed a commit to whatadayG/verl that referenced this pull request Sep 5, 2025
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

In scenarios involving multiple validation sets, where the difficulty
levels of these sets differ significantly and the generated content
lengths vary notably, the order in which the validation sets are
processed can have a substantial impact on the validation speed.

### High-Level Design

add validation shuffle

### Usage Example

> Provide usage example(s) for easier usage.

```python
validation_shuffle: True
```

### Test

Validation speed increase of over 10%.

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [ ] Add `[BREAKING]` to the PR title if it breaks any API.
- [ ] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [ ] New CI unit test(s) are added to cover the code path.
- [ ] Rely on existing unit tests on CI that covers the code path.
chenjiaoAngel added a commit to chenjiaoAngel/verl that referenced this pull request Nov 14, 2025
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

In scenarios involving multiple validation sets, where the difficulty
levels of these sets differ significantly and the generated content
lengths vary notably, the order in which the validation sets are
processed can have a substantial impact on the validation speed.

### High-Level Design

add validation shuffle

### Usage Example

> Provide usage example(s) for easier usage.

```python
validation_shuffle: True
```

### Test

Validation speed increase of over 10%.

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [ ] Add `[BREAKING]` to the PR title if it breaks any API.
- [ ] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [ ] New CI unit test(s) are added to cover the code path.
- [ ] Rely on existing unit tests on CI that covers the code path.
TimurTaepov pushed a commit to giorgossideris/verl that referenced this pull request Dec 20, 2025
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

In scenarios involving multiple validation sets, where the difficulty
levels of these sets differ significantly and the generated content
lengths vary notably, the order in which the validation sets are
processed can have a substantial impact on the validation speed.

### High-Level Design

add validation shuffle

### Usage Example

> Provide usage example(s) for easier usage.

```python
validation_shuffle: True
```

### Test

Validation speed increase of over 10%.

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [ ] Add `[BREAKING]` to the PR title if it breaks any API.
- [ ] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [ ] New CI unit test(s) are added to cover the code path.
- [ ] Rely on existing unit tests on CI that covers the code path.
vyomakesh0728 added a commit to vyomakesh0728/verl that referenced this pull request Jan 22, 2026
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

In scenarios involving multiple validation sets, where the difficulty
levels of these sets differ significantly and the generated content
lengths vary notably, the order in which the validation sets are
processed can have a substantial impact on the validation speed.

### High-Level Design

add validation shuffle

### Usage Example

> Provide usage example(s) for easier usage.

```python
validation_shuffle: True
```

### Test

Validation speed increase of over 10%.

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [ ] Add `[BREAKING]` to the PR title if it breaks any API.
- [ ] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [ ] New CI unit test(s) are added to cover the code path.
- [ ] Rely on existing unit tests on CI that covers the code path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants