-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[trainer, cfg] feat: add BaseConfig for all dataclass configs. Introduce dataclass for algorithm related configs #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-haibin-lin
merged 36 commits into
verl-project:main
from
eric-haibin-lin:feat/algorithm-config-dataclass
Jul 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
4e1c05e
[trainer, cfg] feat: Add AlgorithmConfig dataclass for type-safe algo…
openhands-agent 9ed10fa
Complete algorithm config dataclass migration
openhands-agent 646a1e7
Remove temporary test files
openhands-agent d7aa12b
Revert changes and rename algorithm config to algo config
openhands-agent 109340d
Update compute_advantage type annotations and fix linting
openhands-agent 89e4b34
Update all core_algos.py functions to use AlgoConfig type annotations
openhands-agent f0f406f
Fix compute_grpo_outcome_advantage function signature to include Algo…
openhands-agent 637a358
Merge main into feat/algorithm-config-dataclass
openhands-agent 9eeab2e
init frozen adaptor
eric-haibin-lin 1b85290
move to profiler folder
eric-haibin-lin ba93223
backward compat namespace move
eric-haibin-lin da8d771
fix lint
eric-haibin-lin 0b1cb62
remove omega_conf_to_dataclass type
eric-haibin-lin 2c25c76
Refactor algorithm config classes to use frozen dataclasses and BaseC…
devin-ai-integration[bot] 520b23d
Revert documentation changes and fix omega_conf_to_dataclass call
devin-ai-integration[bot] 80685b4
Fix config.get() call in compute_advantage function
devin-ai-integration[bot] 2df1773
Merge main branch and resolve conflicts
devin-ai-integration[bot] 52c62b3
Fix lint issues after merge
devin-ai-integration[bot] 562a111
Fix type annotation and docstring coverage issues
devin-ai-integration[bot] 81d7edf
Add test_base_config_on_cpu.py to allow list and update omega_conf_to…
devin-ai-integration[bot] a6df414
fix test
eric-haibin-lin 6e743a5
fix litn
eric-haibin-lin ffa8d77
convert to dataclass upfront
eric-haibin-lin 12c22b8
Merge branch 'feat/algorithm-config-dataclass' of code.byted.org:data…
eric-haibin-lin e2fac2c
update import stmt
eric-haibin-lin 969a734
merge with main
eric-haibin-lin 69a1a17
fix lint
eric-haibin-lin f1f4047
add _target_ to megatron config
eric-haibin-lin 7bcd0fe
fix ranks init
eric-haibin-lin 0eacb9f
adjust line-len
eric-haibin-lin ac19891
adjust len=120
eric-haibin-lin c907607
merge with main
eric-haibin-lin e63bbb0
fix lint
eric-haibin-lin 8bce67d
merge with master
eric-haibin-lin fb93f20
merge with main
eric-haibin-lin c195f00
Merge remote-tracking branch 'oss/main' into feat/algorithm-config-da…
eric-haibin-lin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move to profiler folder
- Loading branch information
commit 1b85290a11ec656c7bda1c62461450f4998ba0f0
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verl/utils/debug/init.py imports * from profiler. the impact is acceptable