[misc] fix: sft SFT E2E CI test failure due to megatron engine#3786
Merged
vermouth1992 merged 3 commits intoverl-project:mainfrom Oct 16, 2025
Merged
[misc] fix: sft SFT E2E CI test failure due to megatron engine#3786vermouth1992 merged 3 commits intoverl-project:mainfrom
vermouth1992 merged 3 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a CI test failure within the SFT E2E tests concerning the Megatron engine. The primary fix, located in verl/models/mcore/util.py, correctly introduces a continue statement. This prevents a logical fall-through in the preprocess_packed_seqs_no_padding function when cp_size <= 1, which is a critical correction. The other modifications, such as removing a debug print statement and enhancing comments by replacing FIXMEs with detailed explanations, improve the code's clarity and maintainability. The changes are accurate and well-implemented, making the PR ready for merging.
8808518 to
53d0f0f
Compare
vermouth1992
approved these changes
Oct 16, 2025
masoudhashemi
pushed a commit
to masoudhashemi/verl
that referenced
this pull request
Oct 19, 2025
wangboxiong320
pushed a commit
to wangboxiong320/verl
that referenced
this pull request
Nov 1, 2025
NenoL2001
pushed a commit
to NenoL2001/verl
that referenced
this pull request
Nov 3, 2025
AlexJJ009
pushed a commit
to AlexJJ009/verl
that referenced
this pull request
Nov 5, 2025
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
chenhaiq
pushed a commit
to The-Hierophant/verl-1
that referenced
this pull request
Nov 18, 2025
NenoL2001
pushed a commit
to NenoL2001/verl
that referenced
this pull request
Nov 26, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the SFT E2E CI test failure caused by the Megatron engine integration (issue introduced in #3600).
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)