Skip to content

[sglang] Fixing issues in examples/sglang_multiturn/search_r1_like/run_qwen2.5-3b_instruct_search_multiturn.sh#5114

Open
NLPJCL wants to merge 3 commits intoverl-project:mainfrom
NLPJCL:main
Open

[sglang] Fixing issues in examples/sglang_multiturn/search_r1_like/run_qwen2.5-3b_instruct_search_multiturn.sh#5114
NLPJCL wants to merge 3 commits intoverl-project:mainfrom
NLPJCL:main

Conversation

@NLPJCL
Copy link

@NLPJCL NLPJCL commented Jan 29, 2026

What does this PR do?

When training search-r1 using Verl, I found that the script wouldn't run. This was probably because subsequent updates to the Verl agent loop didn't have compatible parameters. After fixing it, it started running.

  1. To adapt to the tool call format of Verl's agentlloop, the prompt of search-r1 was modified.
  2. actor_rollout_ref.rollout.multi_turn.format: Modify the template from non-existent qwen to hermes.
  3. actor_rollout_ref.rollout.multi_turn.max_assistant_turns=4; if actor_rollout_ref.rollout.multi_turn.max_assistant_turns set=2,It only performs one search, which is inconsistent with the multi-round search in search-r1.
  4. actor_rollout_ref.rollout.multi_turn.max_tool_response_length=1024. Since local search wikis are composed of English words, the length of the output mode is increased to avoid truncation by the default configuration.
    if tool_response_text and len(tool_response_text) > self.max_tool_response_length:

    max_tool_response_length: int = 256

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...

  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)

    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Modify the configuration of search-r1 to adapt it to the current agentloop.
Modify the template from non-existent qwen to memes
To adapt to the tool call format of Verl's AgentLoop, modify the prompt as follows:
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2026

CLA assistant check
All committers have signed the CLA.

@NLPJCL
Copy link
Author

NLPJCL commented Jan 31, 2026

Some issues should be held for now. An example of search-r1 should be provided under agentlloop instead of modifying the current one, and some experimental results should be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants