[vllm_fp8_utils] fix: preserve vLLM>=0.12 FP8 Marlin workspace init#5153
Open
JohnConnor123 wants to merge 6 commits intoverl-project:mainfrom
Open
[vllm_fp8_utils] fix: preserve vLLM>=0.12 FP8 Marlin workspace init#5153JohnConnor123 wants to merge 6 commits intoverl-project:mainfrom
JohnConnor123 wants to merge 6 commits intoverl-project:mainfrom
Conversation
Collaborator
|
@JohnConnor123 Can you clarify what GPU you're using? I have reservations about supporting fp8 rollout on GPUs without native fp8 capability. |
Contributor
Author
|
@wuxibin89 I use 2 rtx3090. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspaceattribute (seen asAttributeErrorduring engine init / profiling).process_weights_after_loadingand (for vLLM>=0.12) bypassed vLLM-native Marlin preparation, where vLLM allocates/setslayer.workspace.QKVParallelLinearinstances always have aworkspaceattribute (lazy + idempotent) to avoid early AttributeError.Reproduction
The bug shows up on the Marlin FP8 path (typically GPUs without native FP8 support). If you are on a native-FP8 GPU, you can force Marlin for testing (see below).
Minimal repro script (crashes on
main, fixed on this PR)Expected error (before)
(Triggered from the Marlin FP8 execution path where vLLM uses
workspace=layer.workspace; see vLLM v0.12.0Fp8LinearMethod.apply:https://raw.githubusercontent.com/vllm-project/vllm/v0.12.0/vllm/model_executor/layers/quantization/fp8.py.)Notes on GPU support (native FP8 vs Marlin)
workspacebuffer.layer.workspace, so this crash often does not appear.VLLM_TEST_FORCE_FP8_MARLIN=1(as in the repro script above).Test plan
main→ observe theworkspaceAttributeError (or force Marlin).