[misc] fix: add missing __init__.py files to package directories#5209
Open
guillemgt wants to merge 2 commits intoverl-project:mainfrom
Open
[misc] fix: add missing __init__.py files to package directories#5209guillemgt wants to merge 2 commits intoverl-project:mainfrom
guillemgt wants to merge 2 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds missing __init__.py files to several directories, ensuring they are properly recognized as Python packages. This is a good structural improvement that enhances the project's packaging and import behavior. The changes are straightforward and correct, and I have no further comments.
vermouth1992
reviewed
Feb 6, 2026
| @@ -0,0 +1,14 @@ | |||
| # Copyright 2025 Bytedance Ltd. and/or its affiliates | |||
Collaborator
There was a problem hiding this comment.
This is contributed by Nvidia
Author
There was a problem hiding this comment.
I see. I've updated the license to match the other files in the directory, however they also don't list Nvidia
vermouth1992
reviewed
Feb 6, 2026
verl/experimental/vla/__init__.py
Outdated
| @@ -0,0 +1,14 @@ | |||
| # Copyright 2025 Bytedance Ltd. and/or its affiliates | |||
| # Copyright 2025 Meituan Ltd. and/or its affiliates | |||
Collaborator
There was a problem hiding this comment.
Is VLA contributed by Meituan?
20d6eb1 to
69df06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing
__init__.pyfiles to 11 package directories that contained Python modules but were not properly configured as packages. This ensures these directories are recognized as importable Python packages.Affected directories:
experimental/(fully_async_policy, one_step_off_policy, vla/*, reward_loop/router, transfer_queue)tools/utils/mcp_clients/utils/sglang/workers/rollout/trtllm_rollout/All files include proper Apache 2.0 license headers consistent with the project.
Checklist Before Starting
[{modules}] {type}: {description}Test
Confirmed that affected modules can be imported after the change.
No functional changes - only adds empty files with license headers. Existing tests should continue to pass.
Checklist Before Submitting