Skip to content

[algo] feat: support router replay in MegatronEngine #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xhx1022 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[algo] feat: support router replay in MegatronEngine #5219

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
151928c
support r2,r3 in engine mode
xhx1022 Jan 19, 2026
3b81925
update
xhx1022 Feb 6, 2026
35c6ab2
fixed bug
xhx1022 Feb 6, 2026
e9da9c1
update
xhx1022 Feb 6, 2026
6f914f9
add ValueError
xhx1022 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add ValueError 
Signed-off-by: xhx1022 <1737006628@qq.com>
  • Loading branch information
@xhx1022
xhx1022 committed Feb 7, 2026
commit 6f914f9eedf9ba3a67909b77c08864edde091e70
23 changes: 7 additions & 16 deletions verl/trainer/ppo/ray_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,22 +1520,13 @@ def fit(self):
metrics.update(old_log_prob_metrics)
old_log_prob.batch.pop("entropys")
if "routed_experts" in batch.batch and "routed_experts" in old_log_prob.batch:
if self.use_legacy_worker_impl == "disable":
router_mode = "disabled"
if self.config.actor_rollout_ref.actor.strategy == "megatron":
router_mode = getattr(
self.config.actor_rollout_ref.actor.megatron.router_replay,
"mode",
"disabled",
)
else:
router_mode = getattr(
self.config.actor_rollout_ref.actor.router_replay, "mode", "disabled"
)
if router_mode == "R2":
batch.batch.pop("routed_experts")
else:
old_log_prob.batch.pop("routed_experts")
raise ValueError(
"Detected conflicting router replay configuration: "
"router_replay.mode='R2' and enable_rollout_routing_replay=True "
"cannot be enabled simultaneously. "
"The enable_rollout_routing_replay option is only used in R3 mode; "
"it should not be set when using R2 mode."
)
batch = batch.union(old_log_prob)
if "rollout_log_probs" in batch.batch.keys():
# TODO: we may want to add diff of probs too.
Expand Down
Loading