-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[docker] Update stable image to vllm==0.15.1 #5221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Begunner
wants to merge
11
commits into
verl-project:main
Choose a base branch
from
Begunner:vllm015
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−24
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8fc4203
use vllm015
5d6695b
vllm0151
67f1659
skip apex cuda version check
5f89aaf
preinstall torch2.9.1+cu129
57ce4a9
add cu129
17420a4
limit transformers version
7168447
modify test
aa5557f
mistake
9c3cc77
fix test
81d483f
update readme
13c1c2c
update ci
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add cu129
- Loading branch information
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing
vllmwithout the--no-depsflag may lead to its dependencies, includingtorch, being installed. This could potentially override the specifictorch==2.9.1version installed in the preceding step. If thetorchversion changes, thesedcommand on line 35 will fail as its path is hardcoded fortorch-2.9.1+cu129.dist-info. The previous installation method forvllmused--no-deps, suggesting that dependencies are managed elsewhere. To prevent the build from breaking, you should add the--no-depsflag to this installation command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 here, it's usually safer to fully determine vllm 0.15.1 dependencies, install those first, and install vllm with
--no-deps.You can figure out vllm deps using something like
and can then pin the specific version shown by
uv pip list