Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add cu129
  • Loading branch information
Begunner committed Feb 5, 2026
commit 57ce4a98d14f1e5b66696670428afc131d177883
2 changes: 1 addition & 1 deletion docker/Dockerfile.stable.vllm
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN pip install torch==2.9.1 torchvision torchaudio --index-url https://download
RUN pip install vllm==0.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Installing vllm without the --no-deps flag may lead to its dependencies, including torch, being installed. This could potentially override the specific torch==2.9.1 version installed in the preceding step. If the torch version changes, the sed command on line 35 will fail as its path is hardcoded for torch-2.9.1+cu129.dist-info. The previous installation method for vllm used --no-deps, suggesting that dependencies are managed elsewhere. To prevent the build from breaking, you should add the --no-deps flag to this installation command.

RUN pip install --no-deps vllm==0.15.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here, it's usually safer to fully determine vllm 0.15.1 dependencies, install those first, and install vllm with --no-deps.

You can figure out vllm deps using something like

uv venv --python 3.12 --seed
source .venv/bin/activate
uv pip install vllm==0.15.1
uv pip show vllm

and can then pin the specific version shown by uv pip list


# use cudnn9.16 to avoid conflict
RUN sed -i '/nvidia-cudnn-cu12/d' /usr/local/lib/python3.12/dist-packages/torch-2.9.1.dist-info/METADATA
RUN sed -i '/nvidia-cudnn-cu12/d' /usr/local/lib/python3.12/dist-packages/torch-2.9.1+cu129.dist-info/METADATA
RUN pip install --no-deps --force-reinstall nvidia-cudnn-cu12==9.16.0.29

RUN pip install pybind11
Expand Down