[model, cfg] fix:Allow list of modules to be passed to Lora target_modules#5223
Open
thvasilo wants to merge 4 commits intoverl-project:mainfrom
Open
[model, cfg] fix:Allow list of modules to be passed to Lora target_modules#5223thvasilo wants to merge 4 commits intoverl-project:mainfrom
thvasilo wants to merge 4 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where target_modules could not be a list of strings. The approach of changing the type to Any and adding validation in __post_init__ is a good solution for the OmegaConf limitation. My review includes two main points for improvement: first, to make the validation logic more robust by raising TypeError instead of using assert, as assertions can be disabled. Second, to add unit tests for this new validation logic, as it is currently not covered by the new tests. These changes will improve the correctness and reliability of the configuration handling.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
4091e44 to
dccbe4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5222
PeftConfig from PEFT supports passing a list of strings as
target_modules.However, target_modules is annotated as
Optional[str]inverl/workers/config/model.pywhich leads to runtime errors when trying to override its default"all-linear"value with e.g. a list encoded as JSON string e.g.["q_proj","v_proj"].Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
Added unit test that caught the error (allows replication if you switch the type back to
Optional[str])API and Usage Example
Design & Code Changes
I tried setting the type to
Optional[str | list[str]]but was getting an OmegaConf error because it doesn't support unions in structured configs: omry/omegaconf#144Instead I opted for
Anyand added type checks in__post_init__.Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.