Skip to content

Conversation

Javakky-pxv
Copy link
Contributor

PDO::ATTR_DEFAULT_FETCH_MODE is the key for setAttribute, not fetch_style. (https://www.php.net/manual/en/pdo.setattribute.php)
The default for fetch_style is PDO::FETCH_BOTH, so set it.
(https://www.php.net/manual/en/pdostatement.fetch.php)
And I made it possible to set DEFAULT_FETCH_MODE with setAttribute.
This allows we to omit the fetch argument.

@Javakky-pxv Javakky-pxv force-pushed the feature/default-fetch-mode branch 3 times, most recently from 51bf88d to cf6a4ec Compare March 12, 2021 07:17
@Javakky-pxv Javakky-pxv force-pushed the feature/default-fetch-mode branch from fe0412b to 09f533e Compare March 12, 2021 07:46
@muglug muglug merged commit 9afb99f into vimeo:master Mar 13, 2021
@muglug
Copy link
Collaborator

muglug commented Mar 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants