Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 3, 2022

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/46f74f168a
<?php

$ext = new \ReflectionExtension('ext');
$prettyVersion = $ext->getVersion();
if ($prettyVersion === null) {
    echo "Version is null\n";
}
Psalm output (using commit 8fc499e):

ERROR: TypeDoesNotContainNull - 5:5 - string does not contain null

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 3, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 3, 2022

Thanks for this!

You'll also need to change the Callmap_historical file that should match with Callmap (when there are no change of signature in recent PHP versions)

@orklah orklah merged commit f630a0d into vimeo:4.x Nov 7, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants