Skip to content

Fix Dart #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Dart #17

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
993d660
Fix Dart LSP hover marshalling issue and add integration tests
titanous Aug 8, 2025
a5a3464
Fix Dart LSP definition lookup and add comprehensive tests
titanous Aug 8, 2025
5095722
Fix watcher glob pattern matching for **/*
titanous Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix watcher glob pattern matching for **/* 
The pattern **/* should match all files, but the matching logic was
incorrectly checking if paths ended with a literal asterisk character.
Added special case handling to make **/* match everything, which fixes
the watcher tests.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@titanous @claude
titanous and claude committed Aug 8, 2025
commit 5095722c45431beb583fb869a033c65ac7823e2a
5 changes: 5 additions & 0 deletions internal/watcher/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,11 @@ func matchesSimpleGlob(pattern, path string) bool {
if strings.HasPrefix(pattern, "**/") {
rest := strings.TrimPrefix(pattern, "**/")

// Special case: **/* matches everything
if rest == "*" {
return true
}

// If the rest is a simple file extension pattern like *.go
if strings.HasPrefix(rest, "*.") {
ext := strings.TrimPrefix(rest, "*")
Expand Down